New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DistSQLDatabaseRuleQueryExecutorAssert on ShowMaskRuleExecutorTest #33210

Merged

terrymanu merged 1 commit into apache:master from ilyasahsan123:33142

Oct 13, 2024

Contributor

ilyasahsan123 commented Oct 11, 2024 •

edited by terrymanu

Loading

Changes proposed in this pull request:

Use parameterized DistSQLDatabaseRuleQueryExecutorAssert to instead of DistSQLDatabaseRuleQueryExecutorTest

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.


Implement DistSQLDatabaseRuleQueryExecutorAssert on ShowMaskRuleExecu…

3bba99f

…torTest

Contributor Author

ilyasahsan123 commented Oct 13, 2024

hi @terrymanu, could you please take a look at this? thanks

terrymanu approved these changes

View reviewed changes

terrymanu added the in: test label

terrymanu added this to the 5.5.1 milestone

terrymanu merged commit a68d854 into apache:master

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment