[SPARK-49928][PYTHON][TESTS] Refactor plot-related unit tests #48415
+192
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Irrelevant tests failed, retriggering: |
xinrong-meng
commented
Oct 11, 2024
| def _check_fig_data(self, fig_data, **kwargs): | ||
| for key, expected_value in kwargs.items(): | ||
| if key in ["x", "y", "labels", "values"]: | ||
| converted_values = [v.item() if hasattr(v, "item") else v for v in fig_data[key]] |
There was a problem hiding this comment.
To accommodate the change in the representation of scalars in NumPy 2, see NumPy 2.0 release notes.
There was a problem hiding this comment.
nit, shall we use isinstance(v, np.generic) for this purpose?
There was a problem hiding this comment.
My concern is that might require the numpy dependency. What do you think?
There was a problem hiding this comment.
we can use it with has_numpy
|
cc @zhengruifeng @HyukjinKwon would you please review thanks! |
|
We may later port those expected_fig_data dictionaries to a separate JSON file for easier auditing if the number of tests increases |
zhengruifeng
approved these changes
Oct 11, 2024
xinrong-meng
force-pushed
the
plot_test
branch
from
03e28c2
to
fd31c20
Compare
zhengruifeng
approved these changes
Oct 14, 2024
|
Merged to master, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor plot-related unit tests.
Why are the changes needed?
Different plots have different key attributes of the resulting figure to test against. The refactor makes the comparison easier.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test changes.
Was this patch authored or co-authored using generative AI tooling?
No.