Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Update Zephyr version and Zephyr SDK version #13818

Merged
merged 14 commits into from
Feb 1, 2023

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jan 20, 2023

This PR updates the microTVM code to use Zephyr 3.2 and SDK 0.15.2. Az a result of this change, there are few other changes that are included in this PR:

  • this PR adds a launch script for Zephyr and Arduino template project to run the Project API server from a different Python ENV than TVM Python ENV.
  • For Zephyr, launch script uses global python3.8 which is where west is registered. However, for Arduino it uses a separate virtual ENV with python3 version that exists in the host.
  • removes tests/micro/project_api/test_arduino_microtvm_api_server.py since these tests where using arduino microtvm api server by importing it to TVM. We no longer support Arduino/Zephyr dependencies in TVM testing python ENV.
  • Disables a demo and test due to a CMSIS-NN bug: [Bug] CMSIS-NN BYOC fails with Zephyr 3.2 #13856

There would be a follow up work to move zephyr to a completely separate virtual ENV.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 20, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mehrdadh mehrdadh force-pushed the micro/update_zephyr_version branch 2 times, most recently from 487e094 to 8c906a9 Compare January 25, 2023 18:36
@mehrdadh mehrdadh changed the title [Draft][microTVM]Update Zephyr version and Zephyr SDK version [microTVM]Update Zephyr version and Zephyr SDK version Jan 25, 2023
@mehrdadh mehrdadh marked this pull request as ready for review January 25, 2023 18:40
@mehrdadh mehrdadh force-pushed the micro/update_zephyr_version branch 4 times, most recently from 5ac369b to 23f410d Compare January 27, 2023 22:10
@mehrdadh
Copy link
Member Author

@tvm-bot rerun

@@ -40,15 +42,36 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test that shows how to pass the west_cmd if one doesn't use the default one? If there is not, it would be nice to add one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

west_cmd can be passed as a project option, we also had option to pass it as pytest argument before but since project api uses the west from ENV, we removed that

Copy link
Contributor

@gromero gromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehrdadh Thanks for this PR bumping Zephyr, that's great.

I did a first pass and left a few comments but I need more time to do the second pass.

Overall the Zephyr / Zephyr SDK looks good.

Question: do you really want to remove tests/micro/project_api/test_arduino_microtvm_api_server.py ? If so, could you elaborate a bit more on what you meant by "removed test since it was importing microtvm_api_server to tvm" ? Also, see my comments on touching Arduino code in this PR. I think ideally the Arduino parts should be left to a separate PR.

@gromero gromero changed the title [microTVM]Update Zephyr version and Zephyr SDK version [microTVM] Update Zephyr version and Zephyr SDK version Jan 31, 2023
@mehrdadh mehrdadh requested a review from gromero January 31, 2023 17:23
@mehrdadh mehrdadh requested a review from gromero January 31, 2023 20:11
Copy link
Contributor

@gromero gromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mehrdadh LGTM now 👍

Copy link
Member

@guberti guberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gromero gromero merged commit d6f78b1 into apache:main Feb 1, 2023
@gromero
Copy link
Contributor

gromero commented Feb 1, 2023

@alanmacd @mkatanbaf @guberti Thanks for the reviews. @mehrdadh Thanks a lot for the change. Kudos for the awesome PR description! :-)

@mehrdadh mehrdadh deleted the micro/update_zephyr_version branch February 1, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants