[BYOC] Refine DNNL Codegen #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
reviewed
Apr 9, 2020
masahi
reviewed
Apr 9, 2020
masahi
reviewed
Apr 9, 2020
| CHECK(out_.size() > static_cast<size_t>(op->index)); | ||
|
|
||
| // Only keep the item we want for the child node. | ||
| // FIXME(@comaniac): The other items should still be requried for the primary outputs. |
There was a problem hiding this comment.
This looks ok to me, why "FIXME"? TupleGetItem only cares about one output.
There was a problem hiding this comment.
In terms of the semantic, if we generate a partition function like conv2d->BN->relu, we should have a tuple output with 3 elements (relu_out, BN_out_1, BN_out_2) even the rest 2 are useless. In general we should achieve this semantic, but since no one cares the rest 2 outputs of batch_norm it's fine for now.
masahi
approved these changes
Apr 9, 2020
zhiics
approved these changes
Apr 9, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* Improve DNNL * Add bind params * trigger ci
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* Improve DNNL * Add bind params * trigger ci
dpankratz
pushed a commit
to dpankratz/incubator-tvm
that referenced
this pull request
Apr 24, 2020
* Improve DNNL * Add bind params * trigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple output and merge compiler region support, we can now refine the DNNL codegen to support ops with multiple outputs such as
batch_norm. This PR:batch_norm.batch_norm.TupleGeItemin DNNL codegen.cc @zhiics, @masahi.