Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC] FTVMAnnotateTarget method signature update #6786

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

d-smirnov
Copy link
Contributor

This PR changes signature of FTVMAnnotateTarget to runtime::TypedPackedFunc<bool(const Expr& expr)>
which allows to utilise extra information (e.g. an operation output type) from passed expr argument.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
cc @zhiics @masahi
Also cc @trevor-m @mbaret. Please help double check.

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change may allow us to simplify some logic for Ethos-N as well. I'll leave that for a follow-up patch though.

tests/python/contrib/test_arm_compute_lib/test_conv2d.py Outdated Show resolved Hide resolved
python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff has become registered when it shouldn't be.

python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
python/tvm/relay/op/contrib/arm_compute_lib.py Outdated Show resolved Hide resolved
@trevor-m
Copy link
Contributor

tensorrt.py changes look good

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll block it first due to the unresolved comments. @d-smirnov please address the concern raised by @mbaret.

Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)>
which allows to utilise extra information from passed expr argument.
@comaniac
Copy link
Contributor

comaniac commented Nov 3, 2020

@mbaret PTAL and approve and request changes explicitly. Thanks.

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@comaniac comaniac merged commit 6e36fc4 into apache:main Nov 4, 2020
@comaniac
Copy link
Contributor

comaniac commented Nov 4, 2020

Thanks @d-smirnov @mbaret @lhutton1 @trevor-m

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)>
which allows to utilise extra information from passed expr argument.
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)>
which allows to utilise extra information from passed expr argument.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)>
which allows to utilise extra information from passed expr argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants