Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFLite] Added check for dynamic range quantization #7114

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

d-smirnov
Copy link
Contributor

This PR adds an extra check to prevent optimized with "dynamic range quantization" tflite files to be loaded as this type of Tensorflow optimization is not fully supported in TVM (the optimization creates non-quantized command with quantized weights which cannot be correctly processed now).
https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization

Added check to prevent optimized with "dynamic range quantization"
tflite files to be loaded as the optimization is not fully supported.

https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization
Copy link
Contributor

@giuseros giuseros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments! LGTM now

@d-smirnov
Copy link
Contributor Author

@FrozenGene please, take a look

@d-smirnov
Copy link
Contributor Author

How can we make progress here?

@d-smirnov
Copy link
Contributor Author

@comaniac

@FrozenGene FrozenGene merged commit 2e8133d into apache:main Feb 4, 2021
@FrozenGene
Copy link
Member

Thanks @d-smirnov @d-smirnov merged now

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
* [TFLite] Added check for dynamic range quantization

Added check to prevent optimized with "dynamic range quantization"
tflite files to be loaded as the optimization is not fully supported.

https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization

* linter

* linter

* unit test fix
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
* [TFLite] Added check for dynamic range quantization

Added check to prevent optimized with "dynamic range quantization"
tflite files to be loaded as the optimization is not fully supported.

https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization

* linter

* linter

* unit test fix
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
* [TFLite] Added check for dynamic range quantization

Added check to prevent optimized with "dynamic range quantization"
tflite files to be loaded as the optimization is not fully supported.

https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization

* linter

* linter

* unit test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants