Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY][Parser] Optimize relay parser to restore calls attrs #7347

Merged
merged 5 commits into from
Feb 23, 2021

Conversation

domin1985
Copy link
Contributor

Relay parser does not support to restore the attrs value when it is a non-OpNode call.

To avoid too much modification to the native code, only print out the attrs type key of non-Operator Call in relay printer. Then reconstruct the attrs object after parsing this attrs_type_key value in Relay parser.

@jroesch please review.

…or calls

* To avoid too much modification to the native class, only print out the attrs
  type key of non-Operator Call in relay printer. Then reconstruct the attrs object
  after parsing this attrs type key value in Relay parser.
@jroesch
Copy link
Member

jroesch commented Jan 28, 2021

I think the change makes sense, but could you add a few test cases to the parser and I will take another look? Thanks for the fix!

@domin1985
Copy link
Contributor Author

domin1985 commented Jan 28, 2021

I think the change makes sense, but could you add a few test cases to the parser and I will take another look? Thanks for the fix!

Thanks for the reminder @jroesch

@domin1985
Copy link
Contributor Author

domin1985 commented Feb 2, 2021

Rebased on master.

@domin1985
Copy link
Contributor Author

Please help review @masahi @jroesch.

@jroesch
Copy link
Member

jroesch commented Feb 23, 2021

Sorry I some how missed the notification for this one, LGTM thanks!

@jroesch jroesch merged commit a111803 into apache:main Feb 23, 2021
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
…7347)

* [RELAY][Parser] Optimize relay parser to restore attrs for non-Operator calls

* To avoid too much modification to the native class, only print out the attrs
  type key of non-Operator Call in relay printer. Then reconstruct the attrs object
  after parsing this attrs type key value in Relay parser.

* fix lint

* fix ci

* add test case
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
…7347)

* [RELAY][Parser] Optimize relay parser to restore attrs for non-Operator calls

* To avoid too much modification to the native class, only print out the attrs
  type key of non-Operator Call in relay printer. Then reconstruct the attrs object
  after parsing this attrs type key value in Relay parser.

* fix lint

* fix ci

* add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants