[AOT] Initial implementation of --unpacked-api #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
changed the title
Mousius
force-pushed
the
untyped-operator-pass
branch
from
814ed20
to
40b964d
Compare
|
@giuseros everythings back to green, could you take another look? 😸 |
giuseros
approved these changes
May 24, 2021
Mousius
changed the title
17 tasks
Based on the discussions in the AOT embedded improvements RFC, this adds a flag to the target which changes the internal operators to an unpacked API. The unpacked API spreads the input buffers across the operator function, for example: int32_t operator(void* arg0, void* arg1); As opposed to the traditional packed API: int32_t operator(void** args); Uneffected is the entrypoint function, which retains a packed API for compatibility with other parts of TVM. This is done by changing the passes taken by none entrypoint (CallingConv::kEntryPoint) functions.
This removes the logic for deciding the entrypoint from the compiler passes and instead moves it into the metadata code generation. By moving the generation, we can generate a variety of entrypoints on top of the compiler output (such as the micro entrypoint discussed in the RFC).
(Also contains minor clean up of output variables)
(Also moves the entrypoint name to a constant)
Mousius
force-pushed
the
untyped-operator-pass
branch
from
9dcad5b
to
d1e0ab2
Compare
|
@areusch I think this is good to go, could you take another look? |
|
@areusch I think I've incorporated all the changes and CI is still green 🎉 |
areusch
approved these changes
Jun 4, 2021
|
thanks @Mousius, the PR is now merged! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* [AOT] Initial implementation of --no-typed-operators Based on the discussions in the AOT embedded improvements RFC, this adds a flag to the target which changes the internal operators to an unpacked API. The unpacked API spreads the input buffers across the operator function, for example: int32_t operator(void* arg0, void* arg1); As opposed to the traditional packed API: int32_t operator(void** args); Uneffected is the entrypoint function, which retains a packed API for compatibility with other parts of TVM. This is done by changing the passes taken by none entrypoint (CallingConv::kEntryPoint) functions. * Move entrypoint generation outside of main passes This removes the logic for deciding the entrypoint from the compiler passes and instead moves it into the metadata code generation. By moving the generation, we can generate a variety of entrypoints on top of the compiler output (such as the micro entrypoint discussed in the RFC). * Use buffers in make_unpacked_api tests * Enable --no-typed-operators for llvm * Change --no-typed-operators to --typed-operators=0 to match other options * Refactor typed-operators lookup into use_typed_operators_ (Also contains minor clean up of output variables) * Rename --typed-operators to --unpacked-api (Also moves the entrypoint name to a constant) * Move all properties into init list to avoid double init * Remove AutoTVM breaking default and improve clarity
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* [AOT] Initial implementation of --no-typed-operators Based on the discussions in the AOT embedded improvements RFC, this adds a flag to the target which changes the internal operators to an unpacked API. The unpacked API spreads the input buffers across the operator function, for example: int32_t operator(void* arg0, void* arg1); As opposed to the traditional packed API: int32_t operator(void** args); Uneffected is the entrypoint function, which retains a packed API for compatibility with other parts of TVM. This is done by changing the passes taken by none entrypoint (CallingConv::kEntryPoint) functions. * Move entrypoint generation outside of main passes This removes the logic for deciding the entrypoint from the compiler passes and instead moves it into the metadata code generation. By moving the generation, we can generate a variety of entrypoints on top of the compiler output (such as the micro entrypoint discussed in the RFC). * Use buffers in make_unpacked_api tests * Enable --no-typed-operators for llvm * Change --no-typed-operators to --typed-operators=0 to match other options * Refactor typed-operators lookup into use_typed_operators_ (Also contains minor clean up of output variables) * Rename --typed-operators to --unpacked-api (Also moves the entrypoint name to a constant) * Move all properties into init list to avoid double init * Remove AutoTVM breaking default and improve clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussions in the AOT embedded improvements RFC, this adds a flag to the target which changes the internal operators to an unpacked API. The unpacked API spreads the input buffers across the operator function, for example:
As opposed to the traditional packed API:
Unaffected is the entrypoint function, which retains a packed API for compatibility with other parts of TVM. The entrypoint function is generated as part of the metadata as suggested by @tqchen so we can easily swap it for implementing
--micro-entrypoint.cc: @giuseros @mbaret @manupa-arm @areusch @tqchen