[Frontend][TensorFlow] Move infer_value to _get_list_param #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-m
force-pushed
the
infer-value-list-param
branch
from
491919c
to
c6a5db0
Compare
|
@kevinthesun Could you please review? |
trevor-m
force-pushed
the
infer-value-list-param
branch
from
c6a5db0
to
3e45d1f
Compare
trevor-m
force-pushed
the
infer-value-list-param
branch
from
3e45d1f
to
c1321b9
Compare
|
Thanks @trevor-m |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all instances of
_get_list_paramhave a fallback to useinfer_valueto get a static list, or if they didn't they could only benefit from it. This PR moves that code inside_get_list_paramso it will be used by all ops using_get_list_param.This is helpful for strided_slice because it didn't have the
infer_valuefallback which was causing an error for some models I was trying to compile.