Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CuDNN] Remove GPU dependency from tvm.contrib.cudnn.conv_output_shape #8275

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

Lunderberg
Copy link
Contributor

Previously, if the local server couldn't initialize a CuDNN-enabled
GPU, it couldn't generate code that uses CuDNN's forward conv. This
commit adds a python implementation of conv_output_shape, along with
tests to verify that the outputs are matched to CuDNN's output.

Previously, if the local server couldn't initialize a CuDNN-enabled
GPU, it couldn't generate code that uses CuDNN's forward conv.  This
commit adds a python implementation of conv_output_shape, along with
tests to verify that the outputs are matched to CuDNN's output.
@Lunderberg
Copy link
Contributor Author

Related PR #8276 is for the same goal of allowing CuDNN modules to be build on a local non-GPU machine for use on a remote GPU machine. The two implementations are independent, and are separate PRs for reviewing purposes.

Potential reviewer: @mdw-octoml

Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent change, thanks!

@jwfromm
Copy link
Contributor

jwfromm commented Jun 17, 2021

@icemelon9 it'd be great if you could take a look at this PR and make sure you agree with the change.

Copy link
Contributor

@mdw-octoml mdw-octoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Eric!

@jcf94 jcf94 merged commit ca99552 into apache:main Jun 21, 2021
@Lunderberg Lunderberg deleted the cudnn_no_gpu branch June 21, 2021 04:28
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
apache#8275)

Previously, if the local server couldn't initialize a CuDNN-enabled
GPU, it couldn't generate code that uses CuDNN's forward conv.  This
commit adds a python implementation of conv_output_shape, along with
tests to verify that the outputs are matched to CuDNN's output.

Co-authored-by: Eric Lunderberg <[email protected]>
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
apache#8275)

Previously, if the local server couldn't initialize a CuDNN-enabled
GPU, it couldn't generate code that uses CuDNN's forward conv.  This
commit adds a python implementation of conv_output_shape, along with
tests to verify that the outputs are matched to CuDNN's output.

Co-authored-by: Eric Lunderberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants