[Hexagon] Treat floats as float32 when passing args to offloaded kernels #9010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TVMArg
can hold a floating point value, but it's stored asdouble
. In Hexagon ABI doubles are passed in a register pair, but if the offloaded function was using floats (i.e. float32), it will expect values being passed in single registers. Since floats are much more common on Hexagon, assume all scalar floating point values are floats. This is only an issue with offloading, and can be treated as a limitation (we do something analogous for integers already).