[YUNIKORN-2908] unregister its metrics when a queue is removed #987
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hguo25 is this change ready for review? I can only see two "wip" commits. If it's not ready, please make it draft by clicking on "Convert to Draft". |
|
Also, when ready, squash the commits into a single one and change the commit message to "[YUNIKORN-nnnn] JIRA title" format. Thanks. |
hguo25
force-pushed
the
hguoossremovequeuemetrics
branch
from
88ccbd9
to
e544145
Compare
|
@pbacsko yes it's ready. Squashed commits as you asked. Please review, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Delete all metrics so a deleted queue will not continue to report 'guaranteed resource' 'max resource'
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2908
How should this be tested?
Screenshots (if appropriate)
Questions: