[YUNIKORN-2150] Node resource utilization chart does not render properly #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3 ☔ View full report in Codecov by Sentry. |
wilfred-s
approved these changes
Nov 15, 2023
wilfred-s
pushed a commit
that referenced
this pull request
Nov 15, 2023
Node resource utilization chart does not render properly as it expects multiple resources types. Node utilisation REST was changed to dominant resource only.i Multiple resource types in the REST response could lead to showing the incorrect usage (non dominant one) or for different types after a reload. The REST content shows types in a random way. Closes: #147 Signed-off-by: Wilfred Spiegelenburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix the node resource utilization chart so it can correctly render with dominant resource.
What type of PR is it?
Todos
NA
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2150
How should this be tested?
make test should pass. )
Run
kubectl port-forward svc/yunikorn-service 9889 9080 -n yunikornto forward yunikron rest endpoint.(Do remember to update the core version.)
Open another teminal and run
yarn startand check the result of http://localhost:4200/#/dashboardScreenshots (if appropriate)
Questions:
NA