Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Y axis highlighting during legend series mouseover. #4496

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Restore Y axis highlighting during legend series mouseover. #4496

merged 1 commit into from
Jun 1, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented May 30, 2024

The recent commit 9f1d327 introduced extra CSS selectivity that caused the exclusion of Y axes highlighting. This patch selectively re-adds those chart components.

The intent of commit 9f1d327 is unchanged by this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@rosco54
Restore Y axis highlighting during legend series mouseover.
da15938 
Commit 9f1d327 introduced extra selectivity that excluded Y axes and
this patch selectively adds those chart components.
@rosco54 rosco54 force-pushed the Legend_mouseover_Y_axis_highlighting branch from bfeb619 to da15938 Compare May 30, 2024 08:34
@junedchhipa junedchhipa merged commit 9190caa into apexcharts:main Jun 1, 2024
@rosco54 rosco54 deleted the Legend_mouseover_Y_axis_highlighting branch June 14, 2024 04:01
@samul-1 samul-1 mentioned this pull request Jul 17, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Jul 17, 2024
Open
@Johansnjo Johansnjo mentioned this pull request Jul 17, 2024
Open
@bikramtuladharyipl bikramtuladharyipl mentioned this pull request Jul 17, 2024
Merged
@Sheitak Sheitak mentioned this pull request Jul 17, 2024
Open
@DoanQuangTrinh DoanQuangTrinh mentioned this pull request Jul 17, 2024
Open
@Jay3shRanjan Jay3shRanjan mentioned this pull request Jul 17, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Jul 17, 2024
Open
@Sheitak Sheitak mentioned this pull request Jul 18, 2024
Open
@huawei0915 huawei0915 mentioned this pull request Jul 18, 2024
Open
@Sheitak Sheitak mentioned this pull request Jul 19, 2024
Open
@tarun2001jawla tarun2001jawla mentioned this pull request Jul 20, 2024
Open
This was referenced Jul 20, 2024
Open
Open
Open
Open
Open
Open
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Jul 27, 2024
Open
@samul-1 samul-1 mentioned this pull request Jul 27, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Jul 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Jul 27, 2024
Open
@bikramtuladharyipl bikramtuladharyipl mentioned this pull request Jul 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Jul 28, 2024
Open
@dsindicue dsindicue mentioned this pull request Sep 24, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 24, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 24, 2024
Open
@Wiran-Larbi Wiran-Larbi mentioned this pull request Sep 24, 2024
Open
@dalbahadurbk dalbahadurbk mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@Sandaru-IT21001352 Sandaru-IT21001352 mentioned this pull request Sep 27, 2024
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Sep 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 28, 2024
Open
@Gorila-Ciber Gorila-Ciber mentioned this pull request Sep 29, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 29, 2024
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Sep 29, 2024
Open
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 30, 2024
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Sep 30, 2024
Open
@Sheitak Sheitak mentioned this pull request Oct 1, 2024
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Oct 1, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 1, 2024
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Oct 1, 2024
Open
@l0renz02017 l0renz02017 mentioned this pull request Oct 2, 2024
Open
@Sheitak Sheitak mentioned this pull request Oct 2, 2024
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Open
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 5, 2024
Open
Open
@bmiguelbc16 bmiguelbc16 mentioned this pull request Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedchhipa junedchhipa junedchhipa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosco54 @junedchhipa