Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/toolbar png export file width #4598

Merged

Conversation

rs-tsc
Copy link
Contributor

@rs-tsc rs-tsc commented Jul 30, 2024

New Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@junedchhipa
Copy link
Contributor

The same scale property can be supplied to svg export as well.
Hence, the property should stay at toolbar.export.scale.
Also, please don't include dist files in the PR. They are only generated with a new release

@rs-tsc
Copy link
Contributor Author

rs-tsc commented Jul 31, 2024

Thanks a lot for taking time to review this.
I am not very sure if SVG needs a scale, as is a vector graphics, but that make sense and updated the code accordingly. Also have removed the changes from the dist folder.

@junedchhipa junedchhipa merged commit 2a04c09 into apexcharts:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants