Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain warnings are being treated as errors #255

Closed
kylef opened this issue Mar 22, 2016 · 1 comment · Fixed by #289
Closed

Certain warnings are being treated as errors #255

kylef opened this issue Mar 22, 2016 · 1 comment · Fixed by #289
Labels

Comments

@kylef
Copy link
Member

kylef commented Mar 22, 2016

I'm not sure what the correct behaviour is here. We are raising some "warnings" in parse results, however these are being treated as errors since the parse result doesn't contain other content.

You can find examples of this in both #252 and #254.

element: "parseResult"
content:
  -
    element: "annotation"
    meta:
      classes:
        - "warning"
    attributes:
      code: 4
      sourceMap:
        -
          element: "sourceMap"
          content: []
    content: "no property name"

The solution is that these warnings should actually be errors, or other content (API name, etc) should be in the parse result.

@kylef
Copy link
Member Author

kylef commented Apr 1, 2016

To reproduce currently:

# API
## Resource [/]
### Action [GET]

+ Response 200 (application/json)
    + Attributes
        + Include Example

## Data Structures
### Example (Other)
### Other

element: "parseResult"
content:
  -
    element: "annotation"
    meta:
      classes:
        - "warning"
    attributes:
      code: 1
      sourceMap:
        -
          element: "sourceMap"
          content:
            -
              - 42
              - 32
    content: "Mixin must refer to same type as parent"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant