Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature playwright browser #22

Merged
merged 17 commits into from
Feb 24, 2021
Merged

Feature playwright browser #22

merged 17 commits into from
Feb 24, 2021

Conversation

petrpatek
Copy link
Contributor

Fixes the inconsistent apify of PlaywrightPlugin.launch(). Fixes the hanging proxy servers when launching persistent context.

Copy link
Member

@mnmkng mnmkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will help a lot. Some minor things in the tests, but otherwise good to go.

src/playwright/playwright-browser.js Outdated Show resolved Hide resolved
src/playwright/playwright-plugin.js Outdated Show resolved Hide resolved
test/browser-plugins/plugins.test.js Outdated Show resolved Hide resolved
test/browser-plugins/plugins.test.js Outdated Show resolved Hide resolved
test/browser-plugins/plugins.test.js Outdated Show resolved Hide resolved
test/browser-plugins/plugins.test.js Outdated Show resolved Hide resolved
test/browser-plugins/plugins.test.js Show resolved Hide resolved
test/browser-plugins/plugins.test.js Show resolved Hide resolved
test/browser-plugins/plugins.test.js Outdated Show resolved Hide resolved
test/browser-plugins/plugins.test.js Outdated Show resolved Hide resolved
@mnmkng mnmkng merged commit eda6711 into master Feb 24, 2021
@mnmkng mnmkng deleted the feature/playwright-browser branch February 24, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants