Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Deployment guide #482

Merged
merged 15 commits into from
Sep 11, 2024
Merged

docs: Deployment guide #482

merged 15 commits into from
Sep 11, 2024

Conversation

janbuchar
Copy link
Collaborator

Added a doc page about running crawlers on Apify using the SDK. I tested it, fixes will be required before publishing this.

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Aug 30, 2024
@janbuchar janbuchar requested review from vdusek and B4nan August 30, 2024 13:49
@github-actions github-actions bot added this to the 97th sprint - Tooling team milestone Aug 30, 2024
vdusek
vdusek requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not renderable:

Error: MDX compilation failed for file "/home/vdusek/Projects/crawlee-python/docs/introduction/09_running_in_cloud.mdx"

Also I'm afraid in MDX you have to use:

{/* blahblah */}

for comments instead of:

<!-- blahblah -->

templates/beautifulsoup/Dockerfile Show resolved Hide resolved
@janbuchar janbuchar changed the title doc: Deployment guide docs: Deployment guide Sep 4, 2024
@janbuchar
Copy link
Collaborator Author

Let's bring https://crawlee.dev/docs/deployment/apify-platform over too

@B4nan B4nan mentioned this pull request Sep 4, 2024
Closed
7 tasks
@janbuchar
Copy link
Collaborator Author

It would be useful to install git in the Dockerfile - it's small and it helps with installing python dependencies from github, which is situational, but useful.

@janbuchar janbuchar mentioned this pull request Sep 6, 2024
Closed
vdusek
vdusek requested changes Sep 10, 2024
View reviewed changes
docs/deployment/apify_platform.mdx Outdated Show resolved Hide resolved
website/sidebars.js Outdated Show resolved Hide resolved
docs/introduction/09_running_in_cloud.mdx Outdated Show resolved Hide resolved
docs/introduction/09_running_in_cloud.mdx Outdated Show resolved Hide resolved
docs/introduction/09_running_in_cloud.mdx Outdated Show resolved Hide resolved
docs/introduction/09_running_in_cloud.mdx Outdated Show resolved Hide resolved
docs/deployment/apify_platform.mdx Outdated Show resolved Hide resolved
docs/deployment/apify_platform.mdx Outdated Show resolved Hide resolved
@janbuchar janbuchar marked this pull request as ready for review September 10, 2024 16:05
vdusek
vdusek approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit 66f5253 into master Sep 11, 2024
19 checks passed
@janbuchar janbuchar deleted the deployment-guide branch September 11, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@B4nan B4nan Awaiting requested review from B4nan

Assignees

@janbuchar janbuchar

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
97th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@janbuchar @vdusek