Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify RequestList and RequestProvider interfaces and extract their "tandem" behavior from BasicCrawler #2499

Open
4 tasks
janbuchar opened this issue May 24, 2024 · 0 comments
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Milestone

Comments

@janbuchar
Copy link
Contributor

janbuchar commented May 24, 2024

Initial steps have been taken in #2498.

  • Introduce a IRequestProvider interface
  • Unify IRequestProvider with IRequestList
  • Introduce a "switching" request provider implementation to better encapsulate the logic of "read from list first, add new requests to queue" currently present in BasicCrawler
  • The transfer from request list to request queue should be done in background, not when fetching requests from the queue
@janbuchar janbuchar added the debt Code quality improvement or decrease of technical debt. label May 24, 2024
@janbuchar janbuchar added this to the 4.0 milestone May 24, 2024
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant