Use header-generator to order headers
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnmkng
approved these changes
Aug 10, 2021
B4nan
reviewed
Aug 12, 2021
| @@ -11,7 +11,7 @@ | |||
| ], | |||
| "dependencies": { | |||
| "got-cjs": "12.0.0-beta.3", | |||
| "header-generator": "^1.0.0", | |||
| "header-generator": "^1.1.0-beta.1", | |||
There was a problem hiding this comment.
we should be careful with depending on non stable things, we already got burned recently with a beta of our own package (browser-pool), many actors are not using lock files and would use the latest beta automatically on next run
i am quite fine with depending on beta, but i'd suggest to pin it
cc @mnmkng
There was a problem hiding this comment.
Yeah, we're aware. We did not plan to release it with beta. But it's a good point that pinning it is much safer anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.