Allow aborting all API requests by passing an abortSignal #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must be a signal from a AbortController - either the built-in controller available in Node 16+, or a compatible polyfill.
Closed
|
Published |
|
Amazing, thanks so much @apocas! |
7 tasks
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for an
abortSignaloption in every API method. This fixes #629.This depends on the docker-modem change in apocas/docker-modem#132. You'll need to link that dependency in to test this successfully.
I've added a test just for the
container.wait()method, since that's the most obviously interesting use case, but I think being able to abort all types of requests can be useful in various different contexts.