-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Align apollo-server config with state of embeds (#7432)
We added `hideCookieToggle` and `initialState.includeCookies` in the embedded Sandbox config. We then accidentally added `hideCookieToggle` to the embedded Explorer, and we should have only added it to the embedded Sandbox in this repo. This commit 1. puts `includeCookies` back in the embedded Explorer 2. removes `hideCookieToggle` in the embedded Explorer 3. don't spread the entire config into the explorer config, name the arguments 4. remove redundant `?? undefined`s
- Loading branch information
1 parent
a96aee9
commit 8cbc614
Showing
3 changed files
with
24 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
'@apollo/server': patch | ||
--- | ||
|
||
Bug fix: tldr revert a previous change that stops passing includeCookies from the prod landing page config. | ||
|
||
Who was affected? | ||
|
||
Any Apollo Server instance that passes a `graphRef` to a production landing page with a non-default `includeCookies` value that does not match the `Include cookies` setting on your registered variant on studio.apollographql.com. | ||
|
||
How were they affected? | ||
|
||
From release 4.4.0 to this patch release, folks affected would have seen their Explorer requests being sent with cookies included only if they had set `Include cookies` on their variant. Cookies would not havhe been included by default. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters