Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @apollo/utils.withrequired type to dependencies #160

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

trevor-scheer
Copy link
Member

Fixes #152

WithRequired is transitively part of the public typings for this package so it should be a dependency (not just a development dependency). Currently users who import the AugmentedRequest type exported by this package must bring their own WithRequired (either directly or transitively).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trevor-scheer trevor-scheer merged commit 786c44f into main Feb 6, 2023
@trevor-scheer trevor-scheer deleted the trevor/fix-missing-types branch February 6, 2023 21:42
@github-actions github-actions bot mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RESTDataSource implementation issue with willSendRequest & @apollo/utils.withrequired is a devDependency
1 participant