feat(supergraph): add --output flag
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- useful for big, big composition results; spitting those out to
stdout can take a non-trivial amount of time, especially if they're
using `--output` on the rover side (meaning stdout is useless apart
as a way of communicating the composition result, which can be done
faster with this approach)
aaronArinder
force-pushed
the
aaron/add-output-flag-to-supergraph-compose
branch
from
6462774
to
323acac
Compare
aaronArinder
changed the title
--output flag--output flag
dariuszkuc
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful for big, big composition results; spitting those out to stdout can take a non-trivial amount of time, especially if they're using
--outputon the rover side (meaning stdout is useless apart as a way of communicating the composition result, which can be done faster with this approach)let me know (via slack) if you'd like more details! this is part of trying to figure out a particular customer's pain