Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove WHATWG URL import, use global #2293

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 7, 2022

support for Cloudflare Workers

ref: apollographql/apollo-server#6034

@netlify
Copy link

netlify bot commented Dec 7, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6123019

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dnalborczyk dnalborczyk marked this pull request as ready for review December 7, 2022 03:20
@jeffjakub jeffjakub changed the base branch from main to next March 10, 2023 15:52
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: 7f3a3b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/federation-internals Patch
@apollo/gateway Patch
@apollo/composition Patch
@apollo/query-planner Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trevor-scheer trevor-scheer merged commit 1a555d9 into apollographql:next Mar 10, 2023
clenfest added a commit that referenced this pull request Mar 10, 2023
clenfest added a commit that referenced this pull request Mar 10, 2023
Revert change made in #2293, the router uses deno for the router-bridge, and url is not built in (#2451)
@clenfest
Copy link
Contributor

Unfortunately, we had to revert this PR because it didn't play nicely with deno (used by the router). I can reopen it, but I'm not sure what will need to change on the deno side to allow us to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants