Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tag v0.3 #2301

Conversation

matthew-gordon
Copy link

This PR introduces tag v0.3, which adds support for @tag in an additional location (schema).

@netlify
Copy link

netlify bot commented Dec 13, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit dff0a60

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

internals-js/src/tagSpec.ts Show resolved Hide resolved
@@ -195,6 +195,7 @@ export class FederationSpecDefinition extends FeatureDefinition {
export const FEDERATION_VERSIONS = new FeatureDefinitions<FederationSpecDefinition>(federationIdentity)
.add(new FederationSpecDefinition(new FeatureVersion(2, 0)))
.add(new FederationSpecDefinition(new FeatureVersion(2, 1)))
.add(new FederationSpecDefinition(new FeatureVersion(2, 2)));
.add(new FederationSpecDefinition(new FeatureVersion(2, 2)))
.add(new FederationSpecDefinition(new FeatureVersion(2, 3)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to rebase your branch on top of whatever branch adds in 2.3 support (presumably one of them does it, not sure which though).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it, it's the branch in this PR #2294

Note that it's a branch off of Sylvain's forked repo, so you'l need to add his repo as an upstream so you can pull his branch in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.3 spec was actually added in #2279, but that has been merged now. That said, this is all on the next branch, not the main one, so that's where this should be rebased.

@korinne korinne added this to the 2.3.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants