-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a limit to the number of options for a selection #2880
Conversation
In some cases, the number of options generated for a selection can grow to a huge number, which results in a lot of time spent pruning options and creating plans. The new `pathsLimit` option will put a limit on that number of options
🦋 Changeset detectedLatest commit: dcd405d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the PlanningParameters
type has an argument named config
which should have pathsLimit
in it, so there's no need to manually pass through pathsLimit
.
query-planner-js/src/config.ts
Outdated
* | ||
* The default value is set to 10000 | ||
*/ | ||
pathsLimit: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to use ?
here so that users won't be required to provide the property (and also to not break the API).
pathsLimit: number | |
pathsLimit?: number |
Also could you place this property under the debug
section for now? (Could potentially move it out later, but for now I'd rather we don't make stability guarantees around it.)
alright, looks like it's passing tests now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly mirroring some feedback from standup and some tweaks to wording in the doc string. (Also for some reason I don't understand, we only run prettier
/formatting on the test files and not the main source files, so there's some manual whitespace fixes below as well.)
Also you'll need to add a changeset file to this PR, there's instructions for what changesets are and how to add one in this comment #2880 (comment) . Specifically you'll want to click the second link, which lets you add/commit the file via the GitHub UI. |
Co-authored-by: Sachin D. Shinde <[email protected]>
There may be some automatic formatter somewhere in my vscode. I don't remember setting it up for typescript though |
alright, I think this can be merged now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging it in
This PR was opened by the [Changesets release](https:/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/[email protected] ### Patch Changes - Updated dependencies \[[`7b5b836d15247c997712a47847f603aa5887312e`](7b5b836), [`74ca7dd617927a20d79b824851f7651ef3c40a4e`](74ca7dd), [`3f7392b84f8b626b248b59ce81f193d0f0272045`](3f7392b)]: - @apollo/[email protected] - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Updated dependencies \[[`7b5b836d15247c997712a47847f603aa5887312e`](7b5b836), [`74ca7dd617927a20d79b824851f7651ef3c40a4e`](74ca7dd), [`ffe67dfbdb77d15dde2ab6dee66dba05c7b5c037`](ffe67df)]: - @apollo/[email protected] - @apollo/[email protected] - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Avoid `>=` comparison for `FeatureVersion` objects ([#2883](#2883)) - Fix query planning bug where `__typename` on interface object types in named fragments can cause query plan execution to fail. ([#2886](#2886)) ([#2886](#2886)) ## @apollo/[email protected] ### Patch Changes - fix: handle directive conditions on fragments when building query graphs ([#2875](#2875)) This fix addresses issues with handling fragments when they specify directive conditions: - when exploding the types we were not propagating directive conditions - when processing fragment that specifies super type of an existing type and also specifies directive condition, we were incorrectly preserving the unnecessary type condition. This type condition was problematic as it could be referencing types from supergraph that were not available in the local schema. Instead, we now drop the redundant type condition and only preserve the directives (if specified). - Updated dependencies \[[`7b5b836d15247c997712a47847f603aa5887312e`](7b5b836), [`74ca7dd617927a20d79b824851f7651ef3c40a4e`](74ca7dd)]: - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Add a limit to the number of options for a selection. In some cases, we will generate a lot of possible paths to access a field. There is a process to remove redundant paths, but when the list is too large, that process gets very expensive. To prevent that, we introduce an optional limit that will reject the query if too many paths are generated ([#2880](#2880)) - Updated dependencies \[[`7b5b836d15247c997712a47847f603aa5887312e`](7b5b836), [`74ca7dd617927a20d79b824851f7651ef3c40a4e`](74ca7dd), [`3f7392b84f8b626b248b59ce81f193d0f0272045`](3f7392b)]: - @apollo/[email protected] - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Updated dependencies \[[`7b5b836d15247c997712a47847f603aa5887312e`](7b5b836), [`74ca7dd617927a20d79b824851f7651ef3c40a4e`](74ca7dd)]: - @apollo/[email protected] ## [email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
In some cases, the number of options generated for a selection can grow to a huge number, which results in a lot of time spent pruning options and creating plans. The new
pathsLimit
option will put a limit on that number of options