Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional SourceSpecDefinition validations #2914

Merged
merged 13 commits into from
Jan 24, 2024
Merged

Additional SourceSpecDefinition validations #2914

merged 13 commits into from
Jan 24, 2024

Commits on Jan 23, 2024

  1. Enforce v2.7+ of federation is @link-imported when @source* used.

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b714123 View commit details
    Browse the repository at this point in the history

  2. Allow hyphens in @sourceAPI name.

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f13cd22 View commit details
    Browse the repository at this point in the history

  3. Better exception reporting for SourceSpecDefinition.validateSubgraphS… 

    …chema.
    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    219e2c6 View commit details
    Browse the repository at this point in the history

  4. Don't require header.as or header.value (header.name alone works).

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c3d8b3c View commit details
    Browse the repository at this point in the history

  5. Keep validating after API name mismatch for @source{Type,Field}.

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e41715f View commit details
    Browse the repository at this point in the history

  6. Validate header.as is valid HTTP header name.

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e81bdad View commit details
    Browse the repository at this point in the history

  7. Add more badSchema validation error tests.

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3282924 View commit details
    Browse the repository at this point in the history

  8. Better federation version validation error message. 

    #2914 (comment)
    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    264134e View commit details
    Browse the repository at this point in the history

  9. Even more precise federation version validation message. 

    #2914 (comment)
    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7ced763 View commit details
    Browse the repository at this point in the history

  10. Add changeset

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b9d3b3c View commit details
    Browse the repository at this point in the history

  11. Fix rogue test in Node.js v14.

    @benjamn
    benjamn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4079b9a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Report only nodes: application.sourceAST for consistency. 

    #2914 (comment)
    @benjamn
    benjamn committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    16a346b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into benjamn/additional-SourceSpecDefinition-vali… 

    …dations
    @benjamn
    benjamn authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    066783f View commit details
    Browse the repository at this point in the history