repro bug with repeated fragments spreads and generate query fragments #3042
Conversation
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
|
||
| const withGeneratedFragments = operation.generateQueryFragments(); | ||
| expect(withGeneratedFragments.toString()).toMatchString(` | ||
| { |
There was a problem hiding this comment.
Ignore this expectation, the test fails due to validation errors before this.
Fixes #3042 generateQueryFragments does't handle repeated (... on B { ... on B ... on B } } }) fragments well. Given the query planner can actually generate these query structures, this causes this option to be potentially dangerous, generating invalid subgraph queries. --------- Co-authored-by: Marc-Andre Giroux <[email protected]>
Fixes #3042 generateQueryFragments does't handle repeated (... on B { ... on B ... on B } } }) fragments well. Given the query planner can actually generate these query structures, this causes this option to be potentially dangerous, generating invalid subgraph queries. --------- Co-authored-by: Marc-Andre Giroux <[email protected]>
generateQueryFragmentsdoes't handle repeated (... on B { ... on B ... on B } } }) fragments well. Given the query planner can actually generate these query structures, this causes this option to be potentially dangerous, generating invalid subgraph queries.A failing test is included.