Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fed versions #3171

Merged
merged 3 commits into from
Oct 17, 2024
Merged

docs: fed versions #3171

merged 3 commits into from
Oct 17, 2024

Conversation

shorgi
Copy link
Contributor

@shorgi shorgi commented Oct 17, 2024

Fix spacing and line breaks for Fed versions page

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 17, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/federation@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "federation",
        "branch": "eh/docs/fed-version-spacing"
      }
    }
  }
}
Name Link

Commit

9181bd9

Preview

https://www.apollographql.com/docs/deploy-preview/119068757003914a6575

Build ID

119068757003914a6575

File Changes

0 new, 2 changed, 0 removed
* graphos/reference/federation/versions.mdx
* graphos/reference/federation/errors.mdx

Pages

2


2 pages published. Build will be available for 30 days.

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 9181bd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit 9181bd9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/67113f4ac0aed80008f6684d
😎 Deploy Preview https://deploy-preview-3171--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@shorgi shorgi marked this pull request as ready for review October 17, 2024 16:47
@shorgi shorgi requested a review from a team as a code owner October 17, 2024 16:47
Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to add spacing but keep things horizontal? (I feel like using an extra line break might not be necessary?)

@shorgi
Copy link
Contributor Author

shorgi commented Oct 17, 2024

I wonder if there's a way to add spacing but keep things horizontal? (I feel like using an extra line break might not be necessary?)

I think this has been vertical all along? (Can't prove it with both old docs and wayback machine down ...)

@Meschreiber
Copy link
Contributor

Meschreiber commented Oct 17, 2024

I wonder if there's a way to add spacing but keep things horizontal? (I feel like using an extra line break might not be necessary?)

I think this has been vertical all along? (Can't prove it with both old docs and wayback machine down ...)

I mean the First release: Date vs First release /n date

Current:
image

This PR:
image

@shorgi
Copy link
Contributor Author

shorgi commented Oct 17, 2024

I mean the First release: Date vs First release /n date

ah, I meant that having the /n was what was there before in the old docs. (And there wasn't any period or colon after First release or Minimum router version. they were already on separate lines)

I prefer them on separate lines, easier to scan

@Meschreiber
Copy link
Contributor

Got it. I have a preference for the horizontal version since it seems more natural/space-efficient for me, but I'm fine with whatever you decide!

@shorgi shorgi merged commit c42d9c3 into main Oct 17, 2024
20 checks passed
@shorgi shorgi deleted the eh/docs/fed-version-spacing branch October 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants