Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.22.0 update breaks IE11 compatibility #363

Closed
anton-kapelyushok opened this issue May 29, 2020 · 3 comments
Closed

1.22.0 update breaks IE11 compatibility #363

anton-kapelyushok opened this issue May 29, 2020 · 3 comments
Assignees
Labels

Comments

@anton-kapelyushok
Copy link

anton-kapelyushok commented May 29, 2020

1.22.0 update introduces htmlparser2 ^4.0.0 dependency which depends on entities ^2.0.0 that contains regex unsupported by IE11
https:/fb55/entities/blob/master/src/encode.ts#L65

@anton-kapelyushok anton-kapelyushok added the bug Something isn't working label May 29, 2020
@boutell
Copy link
Member

boutell commented May 29, 2020

This is a transitive dependency, it can't be fixed from here but you can follow the progress in the entities npm module:

fb55/entities#209

You could pin that dependency in package-lock to 2.0.0 if necessary temporarily.

Leaving this open as I'm sure others will have the question.

@abea
Copy link
Contributor

abea commented May 29, 2020

This is instigating us to look at planning a major version update that 1) changes the package main source to index.js directly and 2) provides a separate built version to allow people to continue using it as they are now. The OP issue is from the dependency, but we can get around some of those issues by making it easier for people to require and build this as they need it.

@abea abea self-assigned this May 29, 2020
@abea abea added v2 bug and removed bug Something isn't working labels Jul 16, 2020
@abea
Copy link
Contributor

abea commented Jul 29, 2020

We've published the new major version, removing the build and switching main to index.js. npm i [email protected]

@abea abea closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants