Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when node is using unsafe cltv_expiry_delta value (<18) #88

Closed
manreo opened this issue Jul 15, 2020 · 7 comments
Closed

Warn when node is using unsafe cltv_expiry_delta value (<18) #88

manreo opened this issue Jul 15, 2020 · 7 comments

Comments

@manreo
Copy link

manreo commented Jul 15, 2020

Is your feature request related to a problem? Please describe.
See details here:
lightning/bolts#789
and here:
https://twitter.com/realtbast/status/1283298246983659520

I think it would be very efficient to the network if ThunderHub will show a warning when the node has channels with cltv_expiry_delta lower than the recommended value (there are more than 7k such channels on mainnet)

Describe the solution you'd like
I assume some warning that can be disabled in the settings.

@apotdevin
Copy link
Owner

In the details page if the channel has a lower than recommended CLTV it shows a small warning that you should increase it. Is this what you refer to?

@manreo
Copy link
Author

manreo commented Jul 16, 2020

Amazing! I did not know that.

Not sure how unsecured it is to use a low CLTV (@t-bast?) but maybe you should also add a global warning:
image

Thanks!

@apotdevin
Copy link
Owner

Will look into it, if it makes sense to have a global notification or maybe a bigger notification on the details page

PS: if you go to settings > privacy card > values > hide you can hide all number values on ThunderHub 😉🙈

@t-bast
Copy link

t-bast commented Jul 16, 2020

Using a low cltv_expiry_delta is really asking for trouble (it means you're confident that in case of close, you're able to get many transactions confirmed very quickly - and when on-chain fees spike, you're screwed).

Nodes won't be penalized much in path-finding for using a high enough cltv_expiry_delta, so they should strongly consider it!

@apotdevin
Copy link
Owner

@t-bast thub will show an error if the CLTV is below 14 and a warning if it's below 24, what do you think about these defaults?

@t-bast
Copy link

t-bast commented Jul 17, 2020

@apotdevin great, thanks! Could you bump those values to error below 18 and warning below 34, to match the values in the spec?

Ideally users will read some node operator guide at some point as well (at least if they plan on putting non-negligible amounts) and those guides should explain the trade-offs in details.

@apotdevin
Copy link
Owner

For sure, changed in c05f02a

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants