Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Change the default received onchain address to taproot #542

Merged
merged 2 commits into from
Jul 5, 2023
Merged

[UPDATE] Change the default received onchain address to taproot #542

merged 2 commits into from
Jul 5, 2023

Conversation

twofaktor
Copy link
Contributor

@twofaktor twofaktor commented Jun 29, 2023

Since v0.15.0, LND uses taproot addresses by default

This PR makes changes accordingly to match this update.

Src:
https:/lightningnetwork/lnd/blob/v0-16-4-branch/docs/release-notes/release-notes-0.15.1.md#taproot
lightningnetwork/lnd#6810
lightningnetwork/lnd#6666
lightningnetwork/lnd#6633

Ref:
cb61a50

@twofaktor
Copy link
Contributor Author

@secondl1ght @apotdevin could you review this?

@apotdevin
Copy link
Owner

Looks good! Thanks for the PR!

@apotdevin apotdevin enabled auto-merge (squash) July 4, 2023 00:34
@apotdevin
Copy link
Owner

@twofaktor can you run npm run lint to fix the build pipeline? It should be ready to go after this

@twofaktor
Copy link
Contributor Author

twofaktor commented Jul 4, 2023

@twofaktor can you run npm run lint to fix the build pipeline? It should be ready to go after this

I'm not a developer and I don't know exactly the steps to get that

Please, could you help me? I followed the next steps:

  • Download my modified brach with changes in a folder of my device
  • Go to the thunderhub folder
  • Exec npm install
  • Exec npm run lint

Output: Pages directory cannot be found at /tmp/thunderhub/pages or /tmp/thunderhub/src/pages. If using a custom path, please configure with the `no-html-link-for-pages` rule in your eslint config file.

imagen

I don't know if this is the expected output and how to continue. Could you explain more?

@apotdevin
Copy link
Owner

Hey @twofaktor ! No worries, I'll merge this in and run linting after

@apotdevin apotdevin disabled auto-merge July 5, 2023 21:26
@apotdevin apotdevin merged commit 8f9cd4a into apotdevin:master Jul 5, 2023
@twofaktor twofaktor deleted the default-taproot-adress-receive-onchain-PR branch July 5, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants