Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Boltz swap claim transaction fees #600

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

michael1011
Copy link
Contributor

I am not sure what changed, but the claim transactions that Thunderhub constructs right now are not created with the desired x sat/vbyte the user specifies but with x sat absolute fee.

This PR fixes the bug by using targetFee from boltz-core which allows specifying a sat/vbyte fee as parameter

@apotdevin apotdevin merged commit f92a810 into apotdevin:master Jan 2, 2024
1 check passed
@michael1011 michael1011 deleted the swap-claim-fix branch January 2, 2024 11:55
okjodom pushed a commit to bitsacco/thunderhub that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants