Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] tcpreplay-edit with --fixcsum crushing IP header when there is a VLAN tag #583

Closed
jsbarber opened this issue May 27, 2020 · 4 comments
Closed

[Bug] tcpreplay-edit with --fixcsum crushing IP header when there is a VLAN tag #583

jsbarber opened this issue May 27, 2020 · 4 comments
Assignees
@fklassen
Labels
4.3.3 bug
Milestone
4.3.3

Comments

@jsbarber
Copy link
Contributor

Take any IPv4 packet with a VLAN header. Ask tcpreplay-edit to fix the checksums. The IP header's flags field is crushed by the edit.

Start
tcpdump -i ethX -w /tmp/result.pcap in one window.

In another window, play the attached pcap with
tcpreplay-edit -i ethX --fixcsum vlan1pkt.pcap

vlan1pkt.zip

Kill tcpdump and use wireshark/tshark to examine the packet. See that the IPv4 Flags field has been overwritten with garbage (the checksum value).
@jsbarber jsbarber mentioned this issue May 27, 2020
Merged
@fklassen fklassen self-assigned this May 27, 2020
@fklassen
Copy link
Member

Thanks for the PR. Targeting 4.3.3.

@fklassen fklassen added this to the 4.3.3 milestone May 27, 2020
@fklassen
Copy link
Member

fklassen commented Jun 1, 2020

Validated fix. Thanks for the PR.

image

@fklassen fklassen closed this as completed Jun 1, 2020
@fklassen
Copy link
Member

fklassen commented Jun 3, 2020

Introduced #594. Reopening.

@fklassen fklassen reopened this Jun 3, 2020
@fklassen
Copy link
Member

fklassen commented Jun 3, 2020

Regression issue fixed in #594. There was nothing wrong with the commits in this issue. Rather the fix exposed a HBO.

@fklassen fklassen closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fklassen fklassen

Labels
4.3.3 bug
Projects
None yet
Milestone
4.3.3
Development

No branches or pull requests
2 participants
@fklassen @jsbarber