Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 4.4.0 beta1 fails tests on macOS #695

Closed
fklassen opened this issue Jan 26, 2022 · 1 comment · Fixed by #698
Closed

[Bug] 4.4.0 beta1 fails tests on macOS #695

fklassen opened this issue Jan 26, 2022 · 1 comment · Fixed by #698

Comments

@fklassen
Copy link
Member

fklassen commented Jan 26, 2022 •
edited
Loading

This is probably brought on by Bug #678.

To Reproduce
Steps to reproduce the behavior:

  1. sudo make test

Expected behavior
tests pass

Screenshots

[tcprewrite] Portmap test: make: *** [rewrite_portmap] Error 1
[tcprewrite] Portmap range test: make: *** [rewrite_range_portmap] Error 1
[tcprewrite] Endpoint test: 			OK
[tcprewrite] Pseudo NAT test: 			OK
[tcprewrite] Truncate test: 			OK
[tcprewrite] Pad test: 				OK
[tcprewrite] Seed IP test: make: *** [rewrite_seed] Error 1
[tcprewrite] Src/Dst MAC test: 			OK
[tcprewrite] Layer2 test: 			OK
[tcprewrite] Config/VLAN Add test: 		OK
[tcprewrite] Skip bcast test: make: *** [rewrite_skip] Error 1
[tcprewrite] DLT User test: 			OK
[tcprewrite] DLT Cisco HDLC test: 		OK
[tcprewrite] VLAN 802.1ad test: 		OK
[tcprewrite] VLAN Delete test: 			OK
[tcprewrite] Remove EFCS: 			OK
[tcprewrite] Force TTL: make: *** [rewrite_1ttl] Error 1
[tcprewrite] Increase TTL: make: *** [rewrite_2ttl] Error 1
[tcprewrite] Reduce TTL: make: *** [rewrite_3ttl] Error 1
[tcprewrite] TOS test: 				OK
[tcprewrite] MTU Truncate test: make: *** [rewrite_mtutrunc] Error 1
[tcprewrite] Substitute Src/Dst MAC test: 	OK
[tcprewrite] Seeded MAC test: 			OK
[tcprewrite] Seeded Keep MAC test: 		OK
[tcprewrite] L7 fuzzing test: make: *** [rewrite_l7fuzzing] Error 1
[tcprewrite] TCP sequence test: make: *** [rewrite_sequence] Error 1
[tcprewrite] Fix checksum test: make: *** [rewrite_fixcsum] Error 1
[tcprewrite] Fix length and pad test: 		OK
[tcprewrite] Fix length and truncate test: 	OK
[tcprewrite] Fix length and delete test: 	OK
make: Target `all' not remade because of errors.

image

System (please complete the following information):

  • OS: macOS
  • OS version: 11.6.2
  • Tcpreplay Version: 4.4.0 beta1
fklassen added a commit that referenced this issue Jan 26, 2022
@fklassen
Bug #695 update test.pcap checksums
79f637b 
Better mix of IPv4/IPv6 packets that have and don't have checksum errors

Update test samples to reflect new test reults.
fklassen added a commit that referenced this issue Jan 27, 2022
@fklassen
Bug #695 remove FORCE_ALIGN
1739b50 
macOS 11.6 mistakenly detected as a system that requires FORCE_ALIGN,
which caused many tcprewrite tests to fail. It appears that this code
has become broken over the years, and this bug was never detected. That's
because there probably aren't any ULTRA Sparc systems out there anymore.

Rather than attempting to fix, removed FORCE_ALIGN. Too bad if you still
run an ULTRA Sparc.
fklassen added a commit that referenced this issue Jan 27, 2022
@fklassen
Bug #695 remove FORCE_ALIGN
ed52d1a 
macOS 11.6 mistakenly detected as a system that requires FORCE_ALIGN,
which caused many tcprewrite tests to fail. It appears that this code
has become broken over the years, and this bug was never detected. That's
because there probably aren't any ULTRA Sparc systems out there anymore.

Rather than attempting to fix, removed FORCE_ALIGN. Too bad if you still
run an ULTRA Sparc.
fklassen added a commit that referenced this issue Jan 28, 2022
@fklassen
Bug #695 update test.pcap checksums
5628312 
Better mix of IPv4/IPv6 packets that have and don't have checksum errors

Update test samples to reflect new test reults.
fklassen added a commit that referenced this issue Jan 28, 2022
@fklassen
Bug #695 remove FORCE_ALIGN
dd8a85a 
macOS 11.6 mistakenly detected as a system that requires FORCE_ALIGN,
which caused many tcprewrite tests to fail. It appears that this code
has become broken over the years, and this bug was never detected. That's
because there probably aren't any ULTRA Sparc systems out there anymore.

Rather than attempting to fix, removed FORCE_ALIGN. Too bad if you still
run an ULTRA Sparc.
fklassen added a commit that referenced this issue Jan 28, 2022
@fklassen
Bug #695 update copyright dates
d1e3c12
@fklassen fklassen linked a pull request Jan 28, 2022 that will close this issue
Bug #695 mac os tests fail #698
Merged
fklassen added a commit that referenced this issue Jan 28, 2022
@fklassen
Bug #695 remove FORCE_ALIGN
af0d523 
macOS 11.6 mistakenly detected as a system that requires FORCE_ALIGN,
which caused many tcprewrite tests to fail. It appears that this code
has become broken over the years, and this bug was never detected. That's
because there probably aren't any ULTRA Sparc systems out there anymore.

Rather than attempting to fix, removed FORCE_ALIGN. Too bad if you still
run an ULTRA Sparc.
fklassen added a commit that referenced this issue Jan 28, 2022
@fklassen
Bug #695 update copyright dates
2500a21
fklassen added a commit that referenced this issue Jan 28, 2022
@fklassen
Merge pull request #698 from appneta/Bug_#695_macOS_tests_fail
22cecbb 
Bug #695 mac os tests fail
@fklassen
Copy link
Member Author

fixed in PR #698

fklassen added a commit that referenced this issue Feb 10, 2022
@fklassen
Revert "Bug #695 remove FORCE_ALIGN"
084ec86 
This reverts commit af0d523.

Addresses armhf test failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug #695 mac os tests fail appneta/tcpreplay
1 participant
@fklassen