Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for limiting transmit by time #175

Merged
merged 1 commit into from
Aug 5, 2015
Merged

Add option for limiting transmit by time #175

merged 1 commit into from
Aug 5, 2015

Conversation

dexteradeus
Copy link

Add --duration option which lets the user set the number of seconds to transmit
Implemented similarly to the -L option to break out to the send_packets loop and set the abort flag once we have exceeded the time limit.

Add option for limiting transmit by time
1a53207 
- Add --duration option which lets the user set the number of seconds to
  transmit
- Implemented similarly to the -L option to break out to the
  send_packets loop and set the abort flag once we have exceeded the
  time limit.
@fklassen fklassen self-assigned this Jan 30, 2015
@mmellison
Copy link

👍

1 similar comment
@nuxi
Copy link

nuxi commented Feb 4, 2015

👍

@fklassen
Copy link
Member

fklassen commented Feb 4, 2015

Looks good. Thanks for the much-needed enhancment.

This change is in the area of code as #172 and #173 so I want to test all 3 changes at once. I will schedule for the next beta release.

@fklassen fklassen added this to the 4.1.1 milestone Jun 11, 2015
@fklassen
Copy link
Member

Hi @dexteradeus. I am doing some testing, and I notice that this option slows things down by about 200Mbps on 10GigE. I think there is a way around it. I'll investigate.

root@portwell29:~# /tmp/tcpreplay -i eth7 -Kt --loop 800 /root/smallFlows.pcap
File Cache is enabled
Actual: 11408800 packets (7373224800 bytes) sent in 6.04 seconds.
Rated: 1146774000.0 Bps, 9174.19 Mbps, 1774435.97 pps
Flows: 1209 flows, 188.03 fps, 11394400 flow packets, 14400 non-flow
Statistics for network device: eth7
    Attempted packets:         11408800
    Successful packets:        11408800
    Failed packets:            0
    Truncated packets:         0
    Retried packets (ENOBUFS): 0
    Retried packets (EAGAIN):  0
root@portwell29:~# /tmp/tcpreplay -i eth7 -Kt --duration 5 --loop 800 /root/smallFlows.pcap
File Cache is enabled
Actual: 8647743 packets (5588830473 bytes) sent in 5.00 seconds.
Rated: 1117765800.0 Bps, 8942.12 Mbps, 1729548.25 pps
Flows: 1209 flows, 241.79 fps, 8645501 flow packets, 10926 non-flow
Statistics for network device: eth7
    Attempted packets:         8647743
    Successful packets:        8647743
    Failed packets:            0
    Truncated packets:         0
    Retried packets (ENOBUFS): 0
    Retried packets (EAGAIN):  0

fklassen
fklassen reviewed Jun 12, 2015
View reviewed changes
src/tcpreplay_opts.def
arg-default = -1;
arg-range = "1->";
descrip = "Limit the trasmit duration";
doc = <<- EOText
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. trasmit should be transmit. Also, units are not specified in short help so possibly better to say Limit the number of seconds to send

@fklassen fklassen removed their assignment Jun 12, 2015
fklassen added a commit that referenced this pull request Aug 5, 2015
@fklassen
Merge pull request #175 from dexteradeus/feature-duration-limit
43e95c7 
Add option for limiting transmit by time
@fklassen fklassen merged commit 43e95c7 into appneta:master Aug 5, 2015
@fklassen fklassen mentioned this pull request Dec 17, 2015
Closed
@fklassen
Copy link
Member

FYI, I did some updates. See #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dexteradeus @mmellison @nuxi @fklassen