Directories of pcaps as arguments #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fklassen
changed the base branch from
master
to
PR_#682_stage_pr_from_halver94
|
@halver94 thanks for the PR. Staging to a testing branch, targeting 4.4.0 release |
fklassen
added a commit
that referenced
this pull request
Jan 25, 2022
fklassen
added a commit
that referenced
this pull request
Jan 25, 2022
fklassen
added a commit
that referenced
this pull request
Feb 10, 2022
Fixes regression due to feature #682 - Directories of pcaps as arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes your pcaps are buried deep into some directories and sub-directories. Depending on how many you want to pass to tcpreplay and how long their name are, you may be limited by the shell command line length.
Of course you can do another directory with some symbolic links, but it can be more convenient that tcpreplay loads directly a directory or a list of directories.