Migrate builtin check commands to Plugin crd #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2018 15:46
mirshahriar
force-pushed
the
add-builtin-plugin
branch
from
e14c353
to
199e868
Compare
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=========================================
- Coverage 32.36% 32.27% -0.1%
=========================================
Files 15 15
Lines 1001 1004 +3
=========================================
Hits 324 324
- Misses 623 626 +3
Partials 54 54
Continue to review full report at Codecov.
|
tamalsaha
reviewed
Apr 17, 2018
hack/deploy/searchlight.sh
Outdated
| @@ -260,5 +260,8 @@ for crd in "${crds[@]}"; do | |||
| $ONESSL wait-until-ready crd ${crd}.monitoring.appscode.com || { echo "$crd crd failed to be ready"; exit 1; } | |||
| done | |||
|
|
|||
| echo "creating built-in plugins" | |||
| ${SCRIPT_LOCATION}docs/examples/plugins/plugins.yaml| kubectl apply -f - | |||
tamalsaha
reviewed
Apr 17, 2018
pkg/operator/controller.go
Outdated
| @@ -123,6 +123,11 @@ func (op *Operator) RunWatchers(stopCh <-chan struct{}) { | |||
| } | |||
|
|
|||
| func (op *Operator) Run(stopCh <-chan struct{}) error { | |||
| err := op.MigrateAlerts() | |||
| if err != nil { | |||
| log.Fatalln("Failed alert migrations:", err) | |||
tamalsaha
reviewed
Apr 17, 2018
pkg/operator/migrations.go
Outdated
| } | ||
|
|
||
| if len(errs) > 0 { | ||
| return utilerrors.NewAggregate(errs) |
tamalsaha
reviewed
Apr 17, 2018
| return nil | ||
| } | ||
|
|
||
| func (op *Operator) MigrateNodeAlert() error { |
tamalsaha
reviewed
Apr 17, 2018
plugins/check_event/lib.go
Outdated
| @@ -42,7 +42,7 @@ type options struct { | |||
| contextName string | |||
| // Event check information | |||
| namespace string | |||
| checkInterval time.Duration | |||
| checkInterval int | |||
tamalsaha
reviewed
Apr 17, 2018
plugins/check_event/lib.go
Outdated
| @@ -99,7 +104,16 @@ type serviceOutput struct { | |||
| func (p *plugin) Check() (icinga.State, interface{}) { | |||
| opts := p.options | |||
|
|
|||
| checkTime := time.Now().Add(-(opts.checkInterval + opts.clockSkew)) | |||
| var checkInterval time.Duration = 0 | |||
added 2 commits
April 17, 2018 12:00
tamalsaha
approved these changes
Apr 17, 2018
tamalsaha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.