This repository has been archived by the owner on Jun 25, 2019. It is now read-only.
Feature/map view types #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewtsmith
suggested changes
Dec 5, 2017
lib/map_options.dart
Outdated
|
|
||
| MapOptions( | ||
| {this.showUserLocation: false, | ||
| this.initialCameraPosition: _defaultCamera, | ||
| this.title: ""}); | ||
| this.title: "", | ||
| this.mapViewType}); |
There was a problem hiding this comment.
mapViewType should have a default value of Normal.
lib/map_view_type.dart
Outdated
| @@ -0,0 +1,8 @@ | |||
|
|
|||
| class MapViewType { | |||
| static const int MAP_TYPE_HYBRID = 4; | |||
There was a problem hiding this comment.
Should use dart style here:
none,
hybrid,
satellite,
terrain.
Also, are you confident these int values map the same on iOS and Android?
ios/Classes/MapViewPlugin.m
Outdated
| @@ -31,6 +31,8 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result | |||
| NSDictionary *mapOptions = args[@"mapOptions"]; | |||
| NSDictionary *cameraDict = mapOptions[@"cameraPosition"]; | |||
| self.mapTitle = mapOptions[@"title"]; | |||
|
|
|||
| self.mapViewType = [mapOptions[@"mapViewType"] intValue]; | |||
There was a problem hiding this comment.
current mapViewType could be null or 0 because it's not a required param for MapOptions. You should make sure this is a valid enum value before setting it.
| @@ -95,6 +96,7 @@ class MapViewPlugin(val activity: Activity) : MethodCallHandler { | |||
| toolbarActions = getToolbarActions(call.argument<List<Map<String, Any>>>("actions")) | |||
| showUserLocation = mapOptions["showUserLocation"] as Boolean | |||
| mapTitle = mapOptions["title"] as String | |||
| mapViewType = mapOptions["mapViewType"] as Int | |||
There was a problem hiding this comment.
Not guarantee to not be null currently. You should cast it to Int? and check to make sure it's not null before setting it on mapViewType.
| @@ -35,6 +35,9 @@ class MapActivity : AppCompatActivity(), | |||
| override fun onMapReady(map: GoogleMap) { | |||
| googleMap = map | |||
|
|
|||
| //set mapViewType | |||
There was a problem hiding this comment.
Remove comment. Code is clear enough
matthewtsmith
approved these changes
Dec 11, 2017
Closed
This was referenced Jun 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added fucntionality for configuring
map type, which I raised the issue about changing to Satellite view #7P.S: I will add the same functionality to IOS later next week.
Thanks
Helen