Fix check for REDIS_URL being set and address app hanging with bad REDIS_URL protocol/port combo #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
REDIS_URLin the instructions usestruenotTrue.This also attempts to address @UserNotFound's open issue for the Redis connection hanging when the protocol/port combination is incorrect.
The solution is super hacky because of where it's hanging (connection timeouts aren't applicable for the Redis connection at that point, and for whatever reason it looked like the per-conenection socket timeouts weren't helping either, so this was the best option short of setting socket timeouts globally, which I would bet would have unintended consequences), almost to the point that I'm not sure it's worth actually fixing.