-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert github_content registries including Standard Registry to SQLite for performance when installing them #2520
Comments
I'm not sure if aqua really gets fast by SQLite3. Anyway, about performance we should measure, not guess. |
I recall we chatted about this in a past discussion. Are you beginning to see performance impact? Also if it's the size of a single file that's the problem I'm curious if you've thought about instead having the registry be the actual split yaml files without merging to a single and just have Go load all of those from the directory. curious so no rush in response. There's a few cool local storage packages and I'm interested to see how this works for you. |
I don't think so.
I didn't thought that. |
Feature Overview
Convert github_content registries including Standard Registry to SQLite when installing them.
Why is the feature needed?
Similar with #2517 .
To improve the performance to read the standard registry.
Stanard registry is a huge YAML file over 30,000 lines and aqua needs to read entire files so it has a little overhead to read it.
By converting YAML to SQLite, aqua doesn't need to read all of them.
And registry maintainers don't need to do the conversion themselves because aqua converts them internally.
How to reproduce the issue
No response
Workaround
No response
Example Code
aqua converts
registry.yaml
toregistry.yaml.sqlite3
when aqua installs registries.When aqua reads registries, aqua tries to read
registry.yaml.sqlite3
first.If
registry.yaml.sqlite3
isn't found aqua looks forregistry.yaml
.If
registry.yaml
is found, aqua createsregistry.yaml.sqlite3
.If
registry.yaml
isn't found aqua installs it.Reference
The text was updated successfully, but these errors were encountered: