Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql.Rewrite refactor #218

Open
araddon opened this issue May 5, 2018 · 1 comment
Open

sql.Rewrite refactor #218

araddon opened this issue May 5, 2018 · 1 comment

Comments

@araddon
Copy link
Owner

araddon commented May 5, 2018 •
edited
Loading

Complete re-write of the sql.ReWrite() which is crap code.

Goals:

  • Allow sql.ReWrite to support push-down to different data sources when using multi-source queries (joins, select where in, etc).
  • Allow poly-fill missing feautures (ie, group-by in cassandra) but support partial push-down.
  • Allow function re-write (ie, postgres, mysql, etc have different names for the same functions). Allow a dialect-writer to support function re-write.
@araddon araddon mentioned this issue May 20, 2018
Open
@araddon
Copy link
Owner Author

araddon commented May 27, 2018

plan

  • much better unit tests on the sql-rewrite, and more component oriented
  • allow function or node-level rewrite for different dialects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@araddon