Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected fluorescence time courses also select ROI #359

Open
milesAraya opened this issue Jun 17, 2024 · 2 comments · May be fixed by #402
Open

Selected fluorescence time courses also select ROI #359

milesAraya opened this issue Jun 17, 2024 · 2 comments · May be fixed by #402
Assignees
@milesAraya
Labels
enhancement New feature or request
Milestone
OIST requirements...

Comments

@milesAraya
Copy link
Collaborator

追加機能についての概要
Currently, selecting an cell ROI in VISUALISE-> Select Roi ->cell_roi will make this appear in VISUALISE -> fluorescence (if ref image is linked). However, Selecting an fluorescence ID does not cause the ROI to be selected. This makes editing and removing ROI very difficult for the user. They need to search manually through all the ROI to find the correct one.

重要度
高: この機能を早急に対応しなければ、他の開発に影響を与える。

ブランチ名
develop-main

期限
ASAP

その他
This is a major usability issue.
@milesAraya milesAraya added the enhancement New feature or request label Jun 17, 2024
@milesAraya
Copy link
Collaborator Author

Screenshot 2024-06-17 at 17 20 49

@milesAraya milesAraya linked a pull request Aug 5, 2024 that will close this issue
Open
@milesAraya milesAraya added this to the OIST requirements 2024 milestone Aug 19, 2024
@itutu-tienday itutu-tienday linked a pull request Aug 20, 2024 that will close this issue
Roi time series select colour change #402
Open
@milesAraya
Copy link
Collaborator Author

PR 402 implements the basic functionality of this by

  1. selected ROI turn white
  2. selecting ROI in the legend also turns selected ROI on the map white.

However, when making a test case sheet, it was found that the drag select functionality does not work with this. It seems drag-select and click-select were implemented in separate parallel ways. In order to drag select multiple entries the data type needs to be changed to accept lists.
#402 (comment)

Current issue:
Drag select and then click un-select. (drag select + drag unselect works, click select + click unselect works, but cannot mix these methods)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milesAraya milesAraya

Labels
enhancement New feature or request
Projects
None yet
Milestone
OIST requirements 2024
Development

Successfully merging a pull request may close this issue.

Roi time series select colour change arayabrain/barebone-studio
1 participant
@milesAraya