Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CBRNG in schedules. #2386

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use CBRNG in schedules. #2386

wants to merge 4 commits into from

Conversation

thorstenhater
Copy link
Contributor

Use the R123 threefry generator for (Poisson) schedules.

⚠️ This will change the detailed output for everything using Poisson generators ⚠️

Closes: #2243

boeschf
boeschf approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thorstenhater
Copy link
Contributor Author

cscs-ci run default

@thorstenhater
Copy link
Contributor Author

Thanks for the review. I am hesitant to merge before GPU CI is up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

@bcumming bcumming Awaiting requested review from bcumming

@AdhocMan AdhocMan Awaiting requested review from AdhocMan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use CBRNG for Schedules
2 participants
@thorstenhater @boeschf