You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The solution is to catch what stream.write returns, so we know if we're allowed to keep writing. It's easy to fix but it makes the finish function asynchronous, and you'd need to update the upper libraries (zip-stream and archiver) to support it.
What do you think? Is this on your radar? Do you plan on fixing it?
The text was updated successfully, but these errors were encountered:
Hi 👋
Thank you for creating this nice tool 👌
Problem
I'm experiencing crashes and Out of memory issues when using
archiver
.After investigating, I've discovered that those crashes happen during the
finish
phase, and it's because backpressure isn't respected when writing entries to the central file header.Solution
The solution is to catch what
stream.write
returns, so we know if we're allowed to keep writing. It's easy to fix but it makes thefinish
function asynchronous, and you'd need to update the upper libraries (zip-stream
andarchiver
) to support it.What do you think? Is this on your radar? Do you plan on fixing it?
The text was updated successfully, but these errors were encountered: