Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): filter errors as \null\ while projecting the entity for the key #6441

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Aug 14, 2024

Filter errors as null in the projected key

If the key field has Error, do not send them to the subgraphs as objects but null.

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 5fbdb80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/federation Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/federation 2.2.8-alpha-20240814104345-5fbdb80780d753a50e7b266319bfb789e298f7a8 npm ↗︎ unpkg ↗︎

Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 334       ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 143 kB  14 kB/s
     http_req_blocked...............: avg=4.44µs   min=2.07µs  med=2.66µs   max=254.65µs p(90)=3.88µs   p(95)=4.12µs  
     http_req_connecting............: avg=760ns    min=0s      med=0s       max=126.93µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=55.35ms  min=47.58ms med=50.96ms  max=158.14ms p(90)=64.06ms  p(95)=87.32ms 
       { expected_response:true }...: avg=55.35ms  min=47.58ms med=50.96ms  max=158.14ms p(90)=64.06ms  p(95)=87.32ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 167
     http_req_receiving.............: avg=128.22µs min=95.36µs med=124.89µs max=301.25µs p(90)=141.45µs p(95)=157.83µs
     http_req_sending...............: avg=29.1µs   min=18.93µs med=24.75µs  max=570.03µs p(90)=29.89µs  p(95)=34.86µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=55.19ms  min=47.45ms med=50.82ms  max=157.61ms p(90)=63.93ms  p(95)=87.17ms 
     http_reqs......................: 167     16.640064/s
     iteration_duration.............: avg=60.06ms  min=51.74ms med=55.76ms  max=162.1ms  p(90)=71.95ms  p(95)=90.92ms 
     iterations.....................: 167     16.640064/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://0c3efb81.graphql-tools.pages.dev

@ardatan ardatan merged commit 52a69ed into master Aug 14, 2024
30 checks passed
@ardatan ardatan deleted the filter-rrors-key branch August 14, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants