Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[executors/ws] Allow to configure headers #6540

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

EmrysMyrddin
Copy link
Collaborator

Description

This PR aims to allow users to configure HTTP headers for the WS connection request.
This is needed to allow headers propagation for subscriptions based on WebSockets in Hive Gateway

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: d61ee3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/executor-graphql-ws Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented Sep 25, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-graphql-ws 1.3.0-alpha-20240925200710-d61ee3efd7a824d2ae97ac731770da8ae3a913d0 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Sep 25, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 330       ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 141 kB  14 kB/s
     http_req_blocked...............: avg=4.29µs   min=2.11µs   med=2.79µs   max=189.93µs p(90)=4.21µs   p(95)=4.82µs  
     http_req_connecting............: avg=726ns    min=0s       med=0s       max=119.89µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=56.03ms  min=48.61ms  med=52.61ms  max=160.09ms p(90)=62.37ms  p(95)=82.65ms 
       { expected_response:true }...: avg=56.03ms  min=48.61ms  med=52.61ms  max=160.09ms p(90)=62.37ms  p(95)=82.65ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 165
     http_req_receiving.............: avg=150.25µs min=107.27µs med=133.51µs max=1.04ms   p(90)=159.11µs p(95)=216.28µs
     http_req_sending...............: avg=25.12µs  min=18.36µs  med=24.26µs  max=73.21µs  p(90)=28.47µs  p(95)=32.05µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=55.85ms  min=48.45ms  med=52.45ms  max=159.59ms p(90)=62.09ms  p(95)=82.48ms 
     http_reqs......................: 165     16.480701/s
     iteration_duration.............: avg=60.65ms  min=52.75ms  med=57.13ms  max=164.22ms p(90)=67.86ms  p(95)=86.81ms 
     iterations.....................: 165     16.480701/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Sep 25, 2024

💻 Website Preview

The latest changes are available as preview in: https://7a037b6d.graphql-tools.pages.dev

packages/executors/graphql-ws/src/index.ts Outdated Show resolved Hide resolved
.changeset/cuddly-ants-change.md Outdated Show resolved Hide resolved
@enisdenjo enisdenjo merged commit 1e085bd into master Sep 26, 2024
30 checks passed
@enisdenjo enisdenjo deleted the allow-headers-in-ws-transport branch September 26, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants