Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string title and array source to fix type definition in docs #1173

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Matteo-it
Copy link
Contributor

What This PR Changes

Developing docs 2.0.0 we found some inconsistency with type definition for title and source frontmatter:

  • Title should be a string, in one case we have a number;
  • Source it's unused in docs (i guess), but anyway we managed it as a string. We have one case where we have an array.

Contribution Guidelines

@jhansson-ard
Copy link
Contributor

@Matteo-it do we need some manul updates of the tutorials as well to check that all titles in the frontmatter are strings?

@Matteo-it
Copy link
Contributor Author

Matteo-it commented Jul 12, 2023

@Matteo-it do we need some manul updates of the tutorials as well to check that all titles in the frontmatter are strings?

@jhansson-ard No, I saw that the 2 files I edited are the only two that create type warnings. Anyway it works with number title and array source, but is better remove the easy warning when we found them :)

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 12, 2023

✅ docs-content deploy preview ready

Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matteo-it Matteo-it merged commit bcd81d8 into main Jul 12, 2023
3 checks passed
@Matteo-it Matteo-it deleted the Matteo-it/fix-type-for-docs-warnings branch July 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants