Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pdf sync and invalidate old cloudflare cache #2077

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

Matteo-it
Copy link
Contributor

What This PR Changes

Actually we can't replace a datasheet file and keep the same url, as the files are distributed on a CDN. Since we decided to use static file for datasheet, we need to implement an action to invalidate old cache without store it.

@Matteo-it Matteo-it requested a review from Serjlee July 22, 2024 10:22
@Matteo-it
Copy link
Contributor Author

@Serjlee you have access to repo setting page to add token and secrets?

@Matteo-it Matteo-it marked this pull request as ready for review July 22, 2024 12:04
Copy link
Collaborator

@Serjlee Serjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure to add .pdf as an --exclude of all syncs other than the pdf one, so they don't get deleted and then-reuploaded each time

@Matteo-it
Copy link
Contributor Author

Let's make sure to add .pdf as an --exclude of all syncs other than the pdf one, so they don't get deleted and then-reuploaded each time

Updated both staging and prod actions

@Matteo-it
Copy link
Contributor Author

Hello, @Serjlee, i've try to put this branch in dev https:/arduino/docs-content/actions/runs/10106670041 but it fail. Can you help me to try to understand the problem?

@Matteo-it Matteo-it merged commit efbc5c9 into main Aug 5, 2024
5 checks passed
@Matteo-it Matteo-it deleted the Matteo-it/cdn-assets-update branch August 5, 2024 15:24
Serjlee added a commit that referenced this pull request Aug 6, 2024
Follow up to #2077, where I forgot we got _two_ identical actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants